chore(wallet): Proper Expanded View - #103
Draft
evavirseda wants to merge 49 commits into
Draft
Conversation
…indicator - Account avatar with tooltip (name on hover) at top of sidebar, links to /accounts/manage - Network colored dot above settings at bottom of sidebar, tooltip shows network name, click opens network settings page - Settings button at very bottom of sidebar - Header with account indicator removed from sidebar branch of PageMainLayout (account now lives in sidebar)
- pt-md instead of py-xs for proper spacing above account icon - bg-iota-primary-30 (was bg-iota-primary which has no standalone value)
- Account row: avatar icon + truncated account name (dynamic) - Nav items: switch to NavbarItemType.Vertical with text labels (Home/Assets/Apps/Activity) - Network row: dot + network name (dynamic) - Settings row: icon + 'Settings' label, highlights when menu is open - Sidebar widened from w-16 to w-44 to accommodate labels - Remove Tooltip wrappers (labels are now always visible) - Settings row is a Link directly instead of WalletSettingsButton
- Inline nav item rows with py-[6px] instead of NavbarItemVertical (which hardcodes p-sm and can't be overridden from outside) - Popup width: w-[480px] -> w-[560px] to compensate for wider w-44 sidebar
…th gap - FullScreen: w-44 sidebar with icon + label for all rows - Popup: w-16 sidebar with icons only, centered with gap/spacing - Network row: shows Globe icon in popup mode, dot + name in fullscreen - Revert popup width to w-[480px]
Gate sidebar rendering on bottomNavEnabled flag so connection/approval UI (/dapp/connect/*, /dapp/approve/*) renders without sidebar
Contributor
There was a problem hiding this comment.
LGTM! but I think there is an improvement worth to mention:
apps/wallet/src/ui/app/pages/site-connect/index.tsx
apps/wallet/src/ui/app/pages/approval-request/transaction-request/index.tsx
apps/wallet/src/ui/app/pages/approval-request/SignMessageRequest.tsx
we could remove PageMainLayoutTitle usage in those files in favor of UserApproveContainer.headerTitle property
----
---
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some ideas for a new layout for the wallet, kicked off by @marc2332
