This repository was archived by the owner on Feb 18, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 52
TIP-45: IOTA 2.0 Transaction Payload #147
Draft
PhilippGackstatter
wants to merge
128
commits into
main
Choose a base branch
from
tip45
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TIP-47: Storage Deposit
Updated decays
Changed to a single lookup table
6 tasks
A _Block Issuance Credit Input_ provides the BIC balance of a specific account as context to transaction execution of a | ||
specific slot. It is required for any _Account_ transition and destruction if the account contains a _Block Issuer | ||
Feature_, as any operation on the _Account_ can only be allowed if the BIC balance is non-negative at a specific point | ||
in time. A _Block Issuance Credit Input_ always requires a _Commitment Input_. The input will be resolved to the BIC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A Block Issuance Credit Input always requires a Commitment Input.
This doesn't seem to be true, the node accepts BIC input without a commitment input.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you happen to have an example or a alphanet transaction that shows that?
I don't see how it could get past this check: https://github.com/iotaledger/iota-core/blob/de711606b447c36733ee60d3b72a0932166d07c1/pkg/protocol/engine/ledger/ledger/vm.go#L96.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered Version
Note that: