This repository was archived by the owner on Feb 18, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 52
TIP-42: Account Output Type #144
Draft
PhilippGackstatter
wants to merge
142
commits into
main
Choose a base branch
from
tip42
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Andrew Cullen <45826600+cyberphysic4l@users.noreply.github.com>
Co-authored-by: Thibault Martinez <thibault@iota.org>
tips/TIP-0042/tip-0042.md
Outdated
- A _Commitment Input_ is present. | ||
- A _Block Issuance Credit Input_ is present whose `Account ID` equals that of the account being transitioned. | ||
- When a <i>Block Issuer Feature</i> is present in an account input, the transaction is invalid if that account has | ||
negative Block Issuance Credit, whose value is taken from the _Block Issuance Credit Input_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what "value"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah, that is very unclear from this. I updated the TIP, which raises another question for me: Can you even query the BIC balance of an account via an API at a certain commitment?
This resolution process that is described happens in the node before executing the TX.
Thoralf-M
reviewed
Feb 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered Version
Note that: