-
Notifications
You must be signed in to change notification settings - Fork 62
feat(iota-adapter-transactional-tests): Test randomness for authenticators #9693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iota-adapter-transactional-tests): Test randomness for authenticators #9693
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 6 Skipped Deployments
|
| #[authenticator] | ||
| public fun authenticate( | ||
| _account: &AbstractAccount, | ||
| _random: &mut Random, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test can be removed. It doesn't check randomness, but the verifier rule that is related to mutable references.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed f0cbfb9
miker83z
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you implement a test similar to the attack ptb as in the docs?
5f6b14d to
1d39ec5
Compare
b89b213
into
vm-lang/aa-auth/8805-beta-feature-branch
…ators (#9693) # Description of change New aa tests that use random object have been implemented: `randomness.move` ## Links to any relevant issues Fixed #9583 . ## How the change has been tested Run iota-adapter-transactional-tests tests With `cargo simtest` --------- Co-authored-by: miker83z <mirko.zichichi@iota.org>
…ators (#9693) # Description of change New aa tests that use random object have been implemented: `randomness.move` ## Links to any relevant issues Fixed #9583 . ## How the change has been tested Run iota-adapter-transactional-tests tests With `cargo simtest` --------- Co-authored-by: miker83z <mirko.zichichi@iota.org>
…ators (#9693) # Description of change New aa tests that use random object have been implemented: `randomness.move` ## Links to any relevant issues Fixed #9583 . ## How the change has been tested Run iota-adapter-transactional-tests tests With `cargo simtest` --------- Co-authored-by: miker83z <mirko.zichichi@iota.org>
Description of change
New aa tests that use random object have been implemented:
randomness.moveLinks to any relevant issues
Fixed #9583 .
How the change has been tested
Run iota-adapter-transactional-tests tests
With
cargo simtest