refactor: create dedicated native functions for the AA object creation and support deny for move authenticators #9592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n and support deny for move authenticators # Description of change The account creation Move API was simplified by removing `AuthenticatorInfoV1CompatibilityProof`. Support `Deny` for Move authenticators on the signing phase. ## Links to any relevant issues fixes #9459 fixes #8856 Co-authored-by: Valerii Reutov <valeriy.reutov@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 6 Skipped Deployments
|
iota-ci
added
sc-platform
polinikita
approved these changes
Dec 12, 2025
Member
polinikita
left a comment
polinikita
left a comment
There was a problem hiding this comment.
Approved files owned by consensus
alexsporn
reviewed
Dec 15, 2025
| /// In fact package A may have a dependency on package B version 1, but can still refer to an `authenticate` | ||
| /// function defined in package B version 2. | ||
| /// Referring to an `authenticate` function with `create_auth_info_v1` is a strictly runtime dependency and | ||
| /// Refiring to an `authenticate` function with `create_auth_info_v1` is a strictly runtime dependency and |
Contributor
There was a problem hiding this comment.
Looks like a mistake during merging. Reverted in 4c3f8a7
alexsporn
reviewed
Dec 15, 2025
| /// Borrow the account `UID` mutably. | ||
| /// This function must be called only from the functions protected by the IOTA Move bytecode verifier | ||
| /// from being called outside the `Account` module. | ||
| native fun borrow_account_uid_mut<Account: key>(account: &mut Account): &mut UID; |
Member
There was a problem hiding this comment.
These comments look weird (also in the other functions)
Contributor
There was a problem hiding this comment.
I tried to improve the comments in 4c3f8a7.
Please let me know if you have ideas on how to make them better.
alexsporn
approved these changes
Dec 15, 2025
Member
alexsporn
left a comment
alexsporn
left a comment
There was a problem hiding this comment.
lgtm, just some small comments that needs fixing.
Did not look thoroughly at all the different tests and snapshots.
Dkwcs
approved these changes
Dec 15, 2025
valeriyr
merged commit 8ca2a0c
into
vm-lang/aa-auth/8805-beta-feature-branch
42 checks passed
This was
linked to
issues
Dec 15, 2025
miker83z
added a commit
that referenced
this pull request
Jan 19, 2026
…n and support deny for move authenticators (#9592) The account creation Move API was simplified by removing `AuthenticatorInfoV1CompatibilityProof`. Support `Deny` for Move authenticators on the signing phase. fixes #9459 fixes #8856 - [x] Basic tests (linting, compilation, formatting, unit/integration tests) - [x] Patch-specific tests (correctness, functionality coverage) - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have checked that new and existing unit tests pass locally with my changes --------- Co-authored-by: Valerii Reutov <valeriy.reutov@gmail.com>
miker83z
added a commit
that referenced
this pull request
Jan 26, 2026
…n and support deny for move authenticators (#9592) The account creation Move API was simplified by removing `AuthenticatorInfoV1CompatibilityProof`. Support `Deny` for Move authenticators on the signing phase. fixes #9459 fixes #8856 - [x] Basic tests (linting, compilation, formatting, unit/integration tests) - [x] Patch-specific tests (correctness, functionality coverage) - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have checked that new and existing unit tests pass locally with my changes --------- Co-authored-by: Valerii Reutov <valeriy.reutov@gmail.com>
miker83z
added a commit
that referenced
this pull request
Jan 26, 2026
…n and support deny for move authenticators (#9592) The account creation Move API was simplified by removing `AuthenticatorInfoV1CompatibilityProof`. Support `Deny` for Move authenticators on the signing phase. fixes #9459 fixes #8856 - [x] Basic tests (linting, compilation, formatting, unit/integration tests) - [x] Patch-specific tests (correctness, functionality coverage) - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have checked that new and existing unit tests pass locally with my changes --------- Co-authored-by: Valerii Reutov <valeriy.reutov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The account creation Move API was simplified by removing
AuthenticatorInfoV1CompatibilityProof.Support
Denyfor Move authenticators on the signing phase.Links to any relevant issues
fixes #9459
fixes #8856
How the change has been tested