Skip to content

fix(ledgerjs): Update tests and use nano x #8809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

fix(ledgerjs): Update tests and use nano x #8809

wants to merge 8 commits into from
+111 −66

Conversation

marc2332
Copy link
Contributor

@marc2332 marc2332 commented Oct 8, 2025 •
edited
Loading

  • Switches to Nano X because why not
  • Adapts the tests by adding/removing button presses
  • some sleeps here and there

[run-ci]

@marc2332 marc2332 self-assigned this Oct 8, 2025
@marc2332 marc2332 added the ts-sdk Issues related to the TS SDK label Oct 8, 2025
@vercel Vercel
Copy link

vercel bot commented Oct 8, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
apps-backend Ready Ready Preview Comment Oct 9, 2025 8:17am
iota-evm-bridge Ready Ready Preview Comment Oct 9, 2025 8:17am
rebased-explorer Ready Ready Preview Comment Oct 9, 2025 8:17am
wallet-dashboard Ready Ready Preview Comment Oct 9, 2025 8:17am
2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
apps-ui-kit Ignored Ignored Preview Comment Oct 9, 2025 8:17am
iota-multisig-toolkit Ignored Ignored Preview Oct 9, 2025 8:17am

@github-actions github-actions bot added the ci Issues related to our CI pipeline label Oct 8, 2025
@iota-ci iota-ci added the tooling Issues related to the Tooling team label Oct 8, 2025
@vercel vercel bot temporarily deployed to Preview – apps-backend October 8, 2025 11:19 Inactive
@vercel vercel bot temporarily deployed to Preview – rebased-explorer October 8, 2025 11:19 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-dashboard October 8, 2025 11:19 Inactive
@vercel vercel bot temporarily deployed to Preview – iota-multisig-toolkit October 8, 2025 11:19 Inactive
@vercel vercel bot temporarily deployed to Preview – iota-evm-bridge October 8, 2025 11:19 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025 •
edited
Loading

⚠️ 🦋 Changesets Warning: This PR has changes to public npm packages, but does not contain a changeset. You can create a changeset easily by running pnpm changeset in the root of the IOTA repo, and following the prompts. If your change does not need a changeset (e.g. a documentation-only change), you can ignore this message. This warning will be removed when a changeset is added to this pull request.

Learn more about Changesets.

@marc2332 marc2332 force-pushed the fix/ledgerjs-hq-app-iota-tests branch from c88ca07 to ccfc5f7 Compare October 8, 2025 11:28
@marc2332 marc2332 marked this pull request as draft October 8, 2025 11:28
@marc2332 marc2332 marked this pull request as ready for review October 8, 2025 11:42
@marc2332 marc2332 marked this pull request as draft October 8, 2025 11:50
@Thoralf-M Thoralf-M force-pushed the fix/ledgerjs-hq-app-iota-tests branch 4 times, most recently from aa9860e to 69fbaee Compare October 8, 2025 13:44
@Thoralf-M Thoralf-M force-pushed the fix/ledgerjs-hq-app-iota-tests branch from 69fbaee to 73549a8 Compare October 8, 2025 13:54
@marc2332 marc2332 marked this pull request as ready for review October 8, 2025 14:00
@vercel vercel bot temporarily deployed to Preview – apps-backend October 9, 2025 06:46 Inactive
@vercel vercel bot temporarily deployed to Preview – rebased-explorer October 9, 2025 06:46 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-dashboard October 9, 2025 06:46 Inactive
@vercel vercel bot temporarily deployed to Preview – iota-evm-bridge October 9, 2025 06:46 Inactive
@vercel vercel bot temporarily deployed to Preview – iota-evm-bridge October 9, 2025 06:53 Inactive
@vercel vercel bot temporarily deployed to Preview – iota-multisig-toolkit October 9, 2025 06:53 Inactive
@vercel vercel bot temporarily deployed to Preview – rebased-explorer October 9, 2025 06:53 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-dashboard October 9, 2025 06:53 Inactive
@vercel vercel bot temporarily deployed to Preview – apps-backend October 9, 2025 06:53 Inactive
@github-actions github-actions bot added the wallet Issues related to the IOTA Wallet label Oct 9, 2025
@vercel vercel bot temporarily deployed to Preview – iota-evm-bridge October 9, 2025 07:39 Inactive
@vercel vercel bot temporarily deployed to Preview – apps-backend October 9, 2025 07:39 Inactive
@vercel vercel bot temporarily deployed to Preview – rebased-explorer October 9, 2025 07:39 Inactive
@vercel vercel bot temporarily deployed to Preview – iota-multisig-toolkit October 9, 2025 07:39 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-dashboard October 9, 2025 07:39 Inactive
@marc2332 marc2332 force-pushed the fix/ledgerjs-hq-app-iota-tests branch from 5c339f7 to 6e726d0 Compare October 9, 2025 07:39
@vercel vercel bot temporarily deployed to Preview – iota-evm-bridge October 9, 2025 07:39 Inactive
@vercel vercel bot temporarily deployed to Preview – rebased-explorer October 9, 2025 07:39 Inactive
@vercel vercel bot temporarily deployed to Preview – iota-multisig-toolkit October 9, 2025 07:39 Inactive
@vercel vercel bot temporarily deployed to Preview – apps-backend October 9, 2025 07:39 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-dashboard October 9, 2025 07:39 Inactive
@marc2332 marc2332 marked this pull request as ready for review October 9, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thoralf-M Thoralf-M Thoralf-M approved these changes

@msarcev msarcev Awaiting requested review from msarcev msarcev is a code owner

@alexsporn alexsporn Awaiting requested review from alexsporn alexsporn is a code owner

@thibault-martinez thibault-martinez Awaiting requested review from thibault-martinez thibault-martinez is a code owner

@DaughterOfMars DaughterOfMars Awaiting requested review from DaughterOfMars DaughterOfMars is a code owner

@Dr-Electron Dr-Electron Awaiting requested review from Dr-Electron Dr-Electron is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@marc2332 marc2332

Labels
ci Issues related to our CI pipeline tooling Issues related to the Tooling team ts-sdk Issues related to the TS SDK wallet Issues related to the IOTA Wallet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marc2332 @Thoralf-M @iota-ci