refactor(move-package-alt): Use substring operation instead of lazy regex #8800
+39
−53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Minor refactor for
move-package-alt
, where lazy regex operations were removed in favor of string based ones.Good to know:
The new package cannot be tested using
because it will fail on incorrectly identified doctests.
This, we do not attempt to fix.
The functional way of running the test is:
If you wonder why the main Cargo.lock file was modified it is because of nextest. Not sure why does it change that, why it doesn't fail the same way as the normal
cargo test
though.Links to any relevant issues
fixes #8329