Skip to content

Conversation

TheMrAI
Copy link
Contributor

@TheMrAI TheMrAI commented Oct 8, 2025

Description of change

Minor refactor for move-package-alt, where lazy regex operations were removed in favor of string based ones.

Good to know:
The new package cannot be tested using

external-crates/move $ cargo test -p move-package-alt 

because it will fail on incorrectly identified doctests.

---- crates/move-package-alt/src/dependency/git.rs - dependency::git (line 10) stdout ----
error: expected item, found `.`
 --> crates/move-package-alt/src/dependency/git.rs:11:1
  |
1 | .move/
  | ^ expected item
  |
  = note: for a full list of items that can appear in modules, see <https://doc.rust-lang.org/reference/items.html>

error: aborting due to 1 previous error

This, we do not attempt to fix.
The functional way of running the test is:

external-crates/move $ cargo nextest run -p move-package-alt

If you wonder why the main Cargo.lock file was modified it is because of nextest. Not sure why does it change that, why it doesn't fail the same way as the normal cargo test though.

Links to any relevant issues

fixes #8329

@TheMrAI TheMrAI self-assigned this Oct 8, 2025
@TheMrAI TheMrAI requested a review from a team as a code owner October 8, 2025 08:16
Copy link

vercel bot commented Oct 8, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

6 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
apps-backend Ignored Ignored Preview Oct 8, 2025 8:25am
apps-ui-kit Ignored Ignored Preview Oct 8, 2025 8:25am
iota-evm-bridge Ignored Ignored Preview Oct 8, 2025 8:25am
iota-multisig-toolkit Ignored Ignored Preview Oct 8, 2025 8:25am
rebased-explorer Ignored Ignored Preview Oct 8, 2025 8:25am
wallet-dashboard Ignored Ignored Preview Oct 8, 2025 8:25am

@iota-ci iota-ci added sc-platform Issues related to the Smart Contract Platform group. vm-language Issues related to the VM & Language Team labels Oct 8, 2025
@TheMrAI TheMrAI force-pushed the vm-lang/upstream/8329-switch-to-substring-from-regex branch from 42159fa to c467fe3 Compare October 8, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sc-platform Issues related to the Smart Contract Platform group. vm-language Issues related to the VM & Language Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[mp-alt] Switch to using a substring operation instead of lazy regex · MystenLabs/sui@05ab253a

4 participants