feat(explorer): add address existence check in getResultsForAddress for names #8597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
github-actions
bot
added
explorer
marc2332
requested changes
Sep 22, 2025
apps/explorer/src/hooks/useSearch.ts
Outdated
| ]; | ||
| }; | ||
|
|
||
| async function addressExists(client: IotaClient, address: string): Promise<boolean> { |
There was a problem hiding this comment.
Suggested change
| async function addressExists(client: IotaClient, address: string): Promise<boolean> { | |
| async function isAddress(client: IotaClient, address: string): Promise<boolean> { |
apps/explorer/src/hooks/useSearch.ts
Outdated
|
|
||
| if (!nameRecord || !nameRecord.targetAddress) return null; | ||
|
|
||
| const exists = await addressExists(client, nameRecord.targetAddress); |
There was a problem hiding this comment.
Suggested change
| const exists = await addressExists(client, nameRecord.targetAddress); | |
| const _isAddress = await isAddress(client, nameRecord.targetAddress); |
apps/explorer/src/hooks/useSearch.ts
Outdated
Comment on lines
130
to
140
| const fromTransactions = await client.queryTransactionBlocks({ | ||
| filter: { FromAddress: normalized }, | ||
| limit: 1, | ||
| }); | ||
| if (fromTransactions.data.length > 0) return true; | ||
|
|
||
| const toTransactions = await client.queryTransactionBlocks({ | ||
| filter: { ToAddress: normalized }, | ||
| limit: 1, | ||
| }); | ||
| if (toTransactions.data.length > 0) return true; |
There was a problem hiding this comment.
Wouldn't this also work by doing:
Suggested change
| const fromTransactions = await client.queryTransactionBlocks({ | |
| filter: { FromAddress: normalized }, | |
| limit: 1, | |
| }); | |
| if (fromTransactions.data.length > 0) return true; | |
| const toTransactions = await client.queryTransactionBlocks({ | |
| filter: { ToAddress: normalized }, | |
| limit: 1, | |
| }); | |
| if (toTransactions.data.length > 0) return true; | |
| const transactions = await client.queryTransactionBlocks({ | |
| filter: { FromOrToAddress: { addr: normalized } }, | |
| limit: 1, | |
| }); | |
| if (toTransactions.data.length > 0) return true; |
?
…ame-connected-to-object
msarcev
approved these changes
Oct 7, 2025
marc2332
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.