-
Notifications
You must be signed in to change notification settings - Fork 58
feat(indexer): add streaming support for events and transactions #8555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(indexer): add streaming support for events and transactions #8555
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 6 Skipped Deployments
|
0851a83 to
3b2b54f
Compare
…events and transactions
…rt for events and transactions
…g support for events and transactions
kodemartin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I left a few more comments and suggestions to discuss.
…treaming support for events and transactions
…: add streaming support for events and transactions
…ndexer): add streaming support for events and transactions
… feat(indexer): add streaming support for events and transactions
… fixup! feat(indexer): add streaming support for events and transactions
225537e to
0eaa052
Compare
kodemartin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with a last minor suggestion.
… fixup! fixup! feat(indexer): add streaming support for events and transactions
tomxey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving some nitpicks, but the solution looks good overall. LGTM
… fixup! fixup! fixup! feat(indexer): add streaming support for events and transactions
d1c2a97 to
9a2cd5e
Compare
… fixup! fixup! fixup! fixup! feat(indexer): add streaming support for events and transactions
5299eff
into
sc-platform/feat/streaming-support
# Description of change This PR is the first iteration attempt to provide streaming support for the `iota-indexer` as a library componente. Currently it supports streaming of `StoredEvents` and `StoredTransactions`. It also supports filters. ## Links to any relevant issues fixes #8315 ## How the change has been tested created a separated binary which used the `iota-indexer` as a library, used `testnet` network as source of checkpoints for synchronization, subscribed to incoming events, applied different filter to assert that they were respected. - [x] Basic tests (linting, compilation, formatting, unit/integration tests) - [x] Patch-specific tests (correctness, functionality coverage) ### Infrastructure QA (only required for crates that are maintained by @iotaledger/infrastructure) - [ ] Synchronization of the indexer from genesis for a network including migration objects. - [x] Restart of indexer synchronization locally without resetting the database. - [ ] Restart of indexer synchronization on a production-like database. - [ ] Deployment of services using Docker. - [x] Verification of API backward compatibility. ### Release Notes - [x] Indexer: Add streaming support for `events` and `transactions`.
# Description of change This PR is the first iteration attempt to provide streaming support for the `iota-indexer` as a library componente. Currently it supports streaming of `StoredEvents` and `StoredTransactions`. It also supports filters. ## Links to any relevant issues fixes #8315 ## How the change has been tested created a separated binary which used the `iota-indexer` as a library, used `testnet` network as source of checkpoints for synchronization, subscribed to incoming events, applied different filter to assert that they were respected. - [x] Basic tests (linting, compilation, formatting, unit/integration tests) - [x] Patch-specific tests (correctness, functionality coverage) ### Infrastructure QA (only required for crates that are maintained by @iotaledger/infrastructure) - [ ] Synchronization of the indexer from genesis for a network including migration objects. - [x] Restart of indexer synchronization locally without resetting the database. - [ ] Restart of indexer synchronization on a production-like database. - [ ] Deployment of services using Docker. - [x] Verification of API backward compatibility. ### Release Notes - [x] Indexer: Add streaming support for `events` and `transactions`.
# Description of change This PR is the first iteration attempt to provide streaming support for the `iota-indexer` as a library componente. Currently it supports streaming of `StoredEvents` and `StoredTransactions`. It also supports filters. ## Links to any relevant issues fixes #8315 ## How the change has been tested created a separated binary which used the `iota-indexer` as a library, used `testnet` network as source of checkpoints for synchronization, subscribed to incoming events, applied different filter to assert that they were respected. - [x] Basic tests (linting, compilation, formatting, unit/integration tests) - [x] Patch-specific tests (correctness, functionality coverage) ### Infrastructure QA (only required for crates that are maintained by @iotaledger/infrastructure) - [ ] Synchronization of the indexer from genesis for a network including migration objects. - [x] Restart of indexer synchronization locally without resetting the database. - [ ] Restart of indexer synchronization on a production-like database. - [ ] Deployment of services using Docker. - [x] Verification of API backward compatibility. ### Release Notes - [x] Indexer: Add streaming support for `events` and `transactions`.
Description of change
This PR is the first iteration attempt to provide streaming support for the
iota-indexeras a library componente. Currently it supports streaming ofStoredEventsandStoredTransactions. It also supports filters.Links to any relevant issues
fixes #8315
How the change has been tested
created a separated binary which used the
iota-indexeras a library, usedtestnetnetwork as source of checkpoints for synchronization, subscribed to incoming events, applied different filter to assert that they were respected.Infrastructure QA (only required for crates that are maintained by @iotaledger/infrastructure)
Release Notes
eventsandtransactions.