Skip to content

feat(consensus): Introduce validator scoring metrics #7604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oliviasaa merged 29 commits into from
Jul 21, 2025
Merged

feat(consensus): Introduce validator scoring metrics #7604

oliviasaa merged 29 commits into from
Jul 21, 2025

Conversation

@oliviasaa
Copy link
Contributor

@oliviasaa oliviasaa commented Jul 1, 2025 •
edited
Loading

Description of change

This PR introduces a set of misbehavior-related metrics to be stored by all validators. These same metrics are exposed via Prometheus.

Each validator will track, for each of their peers:

  • Equivocations
  • Missing block proposals
  • Faulty blocks sent to them

Bases on these values, validators also calculate their peers' score.

Notes:

  • Faulty blocks are divided into provable and unprovable, since those misbehaviors could be treated differently.
  • Equivocations and missing block counts are divided into cached and uncached; uncached metrics will never decrease, and rounds that are not cached anymore can be considered "more final" than cached rounds. The uncached metrics also persist in storage.

How the change has been tested

  • Basic tests (linting, compilation, formatting, unit/integration tests)
  • Patch-specific tests (correctness, functionality coverage)
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

Release Notes

  • Protocol: Introduces new Prometheus metrics for validators, which are also locally stored in the node.
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

@vercel
Copy link

vercel bot commented Jul 1, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
apps-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2025 1:09pm
iota-evm-bridge 🛑 Canceled (Inspect) Jul 21, 2025 1:09pm
rebased-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2025 1:09pm
wallet-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2025 1:09pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-ui-kit ⬜️ Ignored (Inspect) Visit Preview 💬 Add feedback Jul 21, 2025 1:09pm
iota-multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Jul 21, 2025 1:09pm

@alexsporn alexsporn changed the title feat(protocol research): Introduce validator scoring metrics feat(consensus): Introduce validator scoring metrics Jul 1, 2025
cyberphysic4l
cyberphysic4l requested changes Jul 9, 2025
View reviewed changes
@iotaledger iotaledger deleted a comment from cyberphysic4l Jul 10, 2025
cyberphysic4l
cyberphysic4l reviewed Jul 10, 2025
View reviewed changes
@oliviasaa oliviasaa marked this pull request as ready for review July 10, 2025 22:12
@oliviasaa oliviasaa requested a review from a team as a code owner July 10, 2025 22:12
@oliviasaa oliviasaa marked this pull request as ready for review July 17, 2025 11:01
piotrm50
piotrm50 requested changes Jul 18, 2025
View reviewed changes
Copy link
Contributor

@piotrm50 piotrm50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment about one last detail that I would change.

piotrm50
piotrm50 reviewed Jul 18, 2025
View reviewed changes
@oliviasaa oliviasaa requested a review from piotrm50 July 18, 2025 13:48
cyberphysic4l
cyberphysic4l approved these changes Jul 21, 2025
View reviewed changes
Copy link
Contributor

@cyberphysic4l cyberphysic4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small requests for final changes, otherwise lgtm

@oliviasaa oliviasaa marked this pull request as draft July 21, 2025 12:33
@oliviasaa oliviasaa marked this pull request as ready for review July 21, 2025 12:47
@oliviasaa oliviasaa merged commit e046ca9 into develop Jul 21, 2025
54 of 55 checks passed
@oliviasaa oliviasaa deleted the protocol-research/feat/metrics-for-score branch July 21, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@piotrm50 piotrm50 piotrm50 approved these changes

@cyberphysic4l cyberphysic4l cyberphysic4l approved these changes

Assignees

No one assigned

Labels

core-protocol research

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@oliviasaa @piotrm50 @cyberphysic4l @iota-ci