Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use N-API 6 builds #1556

Merged
merged 7 commits into from
Feb 7, 2023
Merged

feat: use N-API 6 builds #1556

merged 7 commits into from
Feb 7, 2023

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Feb 6, 2023

Description of change

Update the workflow and prebuild scripts to use N-API 6 builds for the nodeJS bindings.

Links to any relevant issues

#1522

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Run the prebuild scripts locally

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@Tuditi Tuditi added the i-release Infra - Release label Feb 6, 2023
@Tuditi Tuditi self-assigned this Feb 6, 2023
@thibault-martinez thibault-martinez merged commit b41ddd7 into develop Feb 7, 2023
@thibault-martinez thibault-martinez deleted the feat/use-napi-6 branch February 7, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i-release Infra - Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants