fix(graphql-client): Fix an issue that can cause the test_total_transaction_blocks to fail randomly
#77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…saction_blocks` to fail randomly
Alex6323
reviewed
Aug 7, 2025
Comment on lines
+2322
to
+2324
| assert!( | ||
| total_transaction_blocks_by_seq_num >= total_transaction_blocks, | ||
| "expected at least {total_transaction_blocks} transaction blocks, found {total_transaction_blocks_by_seq_num}" |
There was a problem hiding this comment.
this is essentially a race condition, no? Wondering whether we should just change the assert to also just enforce > 0 🤔
There was a problem hiding this comment.
my reasoning is that the assert! should proof something about the internal logic, right? But here ... if you just change the order of calls in this test, the assert will sometimes fail and the test be flaky again.
There was a problem hiding this comment.
don't change the order :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This test can now fail randomly if the queries are not fast enough and return different checkpoints. This fixes the problem by changing the assert.