Integrate product core into identity.rs #1658

chrisgitiota · 2025-04-29T07:48:27Z

Description of change

This PR is the counterpart to the product_core PR
product_core to be used with identity.rs.
Please see there for more details.

This PR is in draft mode and shall facilitate discussing the code changes in identity.rs

Links to any relevant issues

Fixes issue #1636.

Type of change

Add an x to the boxes that are relevant to your changes.

Bug fix (a non-breaking change which fixes an issue)
Enhancement (a non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation Fix
[ x] Architecture-change

How the change has been tested

Local build with identity_iota_core e2e tests

This reverts commit d4e366c.

…uct_core

…to GH feature branch

wulfraem · 2025-05-05T08:18:15Z

identity_iota/Cargo.toml

-identity_iota_interaction = { version = "=1.6.0-alpha", path = "../identity_iota_interaction", default-features = false }
+identity_iota_move_calls = { version = "=1.6.0-alpha", path = "../identity_iota_move_calls", default-features = false }
+iota_interaction = { git = "https://github.com/iotaledger/product-core.git", branch = "feat/transaction-client-core-for-identity", package = "iota_interaction", default-features = false }
+#iota_interaction = { path = "../../product-core/iota_interaction", default-features = false }


Can this be removed? ^^

Suggested change

#iota_interaction = { path = "../../product-core/iota_interaction", default-features = false }

wulfraem · 2025-05-05T08:18:42Z

identity_iota/src/lib.rs

@@ -17,7 +17,7 @@
  clippy::missing_errors_doc
 )]

-pub use identity_iota_interaction as iota_interaction;
+pub use iota_interaction as iota_interaction;


Maybe?

Suggested change

pub use iota_interaction as iota_interaction;

pub use iota_interaction;

wulfraem · 2025-05-05T08:19:13Z

identity_iota_core/Cargo.toml

+iota_interaction = { git = "https://github.com/iotaledger/product-core.git", branch = "feat/transaction-client-core-for-identity", package = "iota_interaction", optional = true }
+#iota_interaction = { path = "../../product-core/iota_interaction", optional = true }
+iota_interaction_rust = { git = "https://github.com/iotaledger/product-core.git", branch = "feat/transaction-client-core-for-identity", package = "iota_interaction_rust", optional = true }
+#iota_interaction_rust = { path = "../../product-core/iota_interaction_rust", optional = true }


Can this be removed? ^^

Suggested change

#iota_interaction_rust = { path = "../../product-core/iota_interaction_rust", optional = true }

wulfraem · 2025-05-05T08:19:24Z

identity_iota_core/Cargo.toml

-identity_iota_interaction = { version = "=1.6.0-alpha", path = "../identity_iota_interaction", default-features = false, optional = true }
-tokio = { version = "1.43", default-features = false, features = ["sync"] }
+iota_interaction = { git = "https://github.com/iotaledger/product-core.git", branch = "feat/transaction-client-core-for-identity", package = "iota_interaction", default-features = false, optional = true }
+#iota_interaction = { path = "../../product-core/iota_interaction", default-features = false, optional = true }


Can this be removed? ^^

Suggested change

#iota_interaction = { path = "../../product-core/iota_interaction", default-features = false, optional = true }

wulfraem · 2025-05-05T08:25:44Z

identity_iota_core/src/rebased/client/read_only.rs

@@ -7,14 +7,14 @@ use std::ops::Deref;
 use std::pin::Pin;
 use std::str::FromStr;

-use crate::rebased::iota;
+use crate::rebased::{iota, rebased_err};


Maybe something like this?

Suggested change

use crate::rebased::{iota, rebased_err};

use crate::rebased::iota;

#[cfg(not(target_arch = "wasm32"))]

use crate::rebased::rebased_err;

wulfraem · 2025-05-05T08:35:44Z

identity_iota_move_calls/Cargo.toml

+iota_interaction.workspace = true
+[target.'cfg(target_arch = "wasm32")'.dependencies]
+iota_interaction = { git = "https://github.com/iotaledger/product-core.git", branch = "feat/transaction-client-core-for-identity", package = "iota_interaction", default-features = false }
+#iota_interaction = { path = "../../product-core/iota_interaction", default-features = false }


Can this be removed? ^^

Suggested change

#iota_interaction = { path = "../../product-core/iota_interaction", default-features = false }

wulfraem · 2025-05-05T08:36:30Z

identity_storage/Cargo.toml

@@ -37,10 +37,12 @@ tokio = { version = "1.43", default-features = false, features = ["macros", "syn
 zkryptium = { workspace = true, optional = true }

 [target.'cfg(not(target_arch = "wasm32"))'.dependencies]
-identity_iota_interaction = { version = "=1.6.0-alpha", path = "../identity_iota_interaction", optional = true }
+iota_interaction = { git = "https://github.com/iotaledger/product-core.git", branch = "feat/transaction-client-core-for-identity", package = "iota_interaction", optional = true }
+#iota_interaction = { path = "../../product-core/iota_interaction", optional = true }


Can this be removed? ^^

Suggested change

#iota_interaction = { path = "../../product-core/iota_interaction", optional = true }

wulfraem · 2025-05-05T08:36:39Z

identity_storage/Cargo.toml


 [target.'cfg(target_arch = "wasm32")'.dependencies]
-identity_iota_interaction = { version = "=1.6.0-alpha", path = "../identity_iota_interaction", default-features = false, optional = true }
+iota_interaction = { git = "https://github.com/iotaledger/product-core.git", branch = "feat/transaction-client-core-for-identity", package = "iota_interaction", default-features = false, optional = true }
+#iota_interaction = { path = "../../product-core/iota_interaction", default-features = false, optional = true }


Can this be removed? ^^

Suggested change

#iota_interaction = { path = "../../product-core/iota_interaction", default-features = false, optional = true }

… lines across codebase

…odules

chrisgitiota added 9 commits April 24, 2025 15:59

Remove all resources that will be provided by product-core

d4e366c

Revert "Remove all resources that will be provided by product-core"

c051c49

This reverts commit d4e366c.

Removed all resources that shall be provided by product-core

a1f6c38

Fixed cargo.toml issues and added product-core dependencies

4f6ebed

First Rust buildable and e2e tested version using product_core

7c75698

First WASM32 (not NodeJS build) buildable untested version using prod…

00cc42c

…uct_core

iota_move_calls_ts buildable with build:nodejs

9e60199

First attempt to accomplish build:nodejs for identity_wasm

2821f20

Switch product_core cargo dependencies from local neighboured folder …

165887b

…to GH feature branch

chrisgitiota added Wasm Related to Wasm bindings. Becomes part of the Wasm changelog Chore Tedious, typically non-functional change No changelog Excludes PR from becoming part of any changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. labels Apr 29, 2025

chrisgitiota added this to the IID-E003: IOTA Identity (v1.6) milestone Apr 29, 2025

chrisgitiota self-assigned this Apr 29, 2025

chrisgitiota requested a review from a team as a code owner April 29, 2025 07:48

Switch product_core cargo dependencies from ssh to https

5d630ab

wulfraem requested changes May 5, 2025

View reviewed changes

itsyaasir and others added 6 commits May 6, 2025 12:05

Merge branch 'main' into chore/product-core-integration

124fb78

refactor: migrate transaction builder to product-core crate

7d0e148

refactor: reorganize imports and split multi-line imports into single…

7ca92da

… lines across codebase

refactor: remove unused imports from identity_move_calls and client m…

b02f330

…odules

chore: clean up commented code and update NetworkName imports

c2e524b

use published interactions

8828b4d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integrate product core into identity.rs #1658

Integrate product core into identity.rs #1658

chrisgitiota commented Apr 29, 2025

wulfraem May 5, 2025

wulfraem May 5, 2025

wulfraem May 5, 2025

wulfraem May 5, 2025

wulfraem May 5, 2025

wulfraem May 5, 2025

wulfraem May 5, 2025

wulfraem May 5, 2025

	pub use iota_interaction as iota_interaction;
	pub use iota_interaction;

Integrate product core into identity.rs #1658

Are you sure you want to change the base?

Integrate product core into identity.rs #1658

Conversation

chrisgitiota commented Apr 29, 2025

Description of change

Links to any relevant issues

Type of change

How the change has been tested

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment