Add core client traits for read-only and read-write IOTA operations #1640
+1,484
−686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UMR1352
reviewed
Apr 15, 2025
UMR1352
requested changes
Apr 15, 2025
…used transaction execution code
chrisgitiota
approved these changes
Apr 17, 2025
eike-hass
force-pushed
the
main
branch
2 times, most recently
from
bb21207 to
42fc734
Compare
…lers that can delegate
…ction methods The changes add OptionalSync bounds to Transaction trait methods and update the CoreClientReadOnly trait to handle object
itsyaasir
added
Breaking change
…ct retrieval methods
* bump version * add toml-cli CI artifacts to gitignore * remove toml-cli CI artifacts --------- Co-authored-by: Identity Bot <identity-bot@iota.org> Co-authored-by: umr1352 <enrico.marconi@iota.org>
* bump version * update well_known_networks --------- Co-authored-by: Identity Bot <identity-bot@iota.org> Co-authored-by: umr1352 <enrico.marconi@iota.org> Co-authored-by: Enrico Marconi <31142849+UMR1352@users.noreply.github.com>
* identity_iota: * "send-sync" is now handed over as "send-sync" to identity_iota_core * "send-sync-storage" is now handed over as "send-sync-storage" to identity_iota_core * examples crate does now use "identity_iota/send-sync" instead of "identity_iota/send-sync-storage" * identity-grpc crate does now use "identity_iota/send-sync" instead of "identity_iota/send-sync-storage"
…" in IdentityClientReadOnly::get_identity() to control Send constraint
…ntityClientReadOnly::get_identity() to control Send constraint + identity_resolver uses "identity_iota_core?/send-sync" now if FF "send-sync-client" is used
chrisgitiota
approved these changes
May 2, 2025
UMR1352
approved these changes
May 5, 2025
identity_iota_core/src/lib.rs
Outdated
There was a problem hiding this comment.
This is an implementation detail that I rather not let users be aware of. Let's keep iota_interaction_rust private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR is for adding the client interfaces as we discussed yesterday. This PR won't be merged in as the client traits will be transferred to
products-corebut I decided to do the leg work so it will be easy to transfer.After the transfer, I will open an issue for the Identity clients to implements the traits as required.
All comments are welcome.
Links to any relevant issues
Be sure to reference any related issues by adding
fixes issue #.Type of change
Add an
xto the boxes that are relevant to your changes.How the change has been tested
Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.
Change checklist
Add an
xto the boxes that are relevant to your changes.