Fix edge case in warpsync which deadlocks syncing #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muXxer
force-pushed
the
fix/warpsync
branch
from
161dd37
to
efcd471
Compare
alexsporn
approved these changes
Sep 21, 2022
muXxer
added a commit
that referenced
this pull request
Dec 27, 2022
muXxer
added a commit
that referenced
this pull request
Jan 9, 2023
* Use iotaledger repository * Update go version to 1.19 * Upgrade libp2p to monorepo version * Fix libp2p connection issue (#1533) * Use fixed private keys in peering tests * Fix libp2p connection issue * Send correct error message if a block is submitted without parents and no PoW is enabled * Add new `/api/routes` endpoint * Block static peers in autopeering module (#1608) * Block static peers in autopeering module * Disable TTL in selection blocklist * Use hive.go chrysalis backports * Avoid locking of the p2p Manager while connection attempts are performed (#1614) * Avoid locking of the p2p Manager while connection attempts are performed * Fix missing handling of peers already known to the manager * Add per-request Rest metrics to prometheus (#1651) * - Add per-request Rest metrics to prometheus * - Made echo dep optional * Extend dockerignore (#1660) * Add new config param to disable snapshot file creation. Defaults to false. (#1711) * Add config parameter to control whether the ledger state is checked on startup. Defaults to false. (#1712) * Add config parameter to control whether the ledger state is checked on startup * Measure and log ledger check time * Added a ledger token supply check to the db-hash tool * Drop unhealthy peers (#1736) * Drop peers that are below our pruning index (#1739) * Fix stuck peer (#1752) * Removed OpenedStream/ClosedStream since they were removed from network.Notifee * Drop connection to peer if the stream is closed * Solidify messages synchronously while they are processed (#1761) * Solidify messages synchronously while they are processed * Only trigger the future cone solidifier if the message is solid * Fix edge case in warpsync which deadlocks syncing (#1763) * Github workflow updates * Update CodeQL action to v2 * Run security-and-quality query suite * Update actions/checkout to v3 * Update docker actions * Add /metadata, /raw, /children endpoints to /included-message * Release v1.2.2 * Read info from SyncManager atomically * Add timestamp funcs to MilestoneStorage * Update workflows * Fix linter errors * Add context to connect and reconnect peer * Fix syncing issue by preventing requests race condition * Address review comments * Update modules * Ignore linter warning Co-authored-by: Alexander Sporn <github@alexsporn.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following edge case:
The node has more than
advancementRangemilestones already in its database, but not confirmed.The solidifier triggers, but can't request the missing parents because of the set filter of
warpsyncin the request queue.The
MilestoneSolidificationFailedtriggers, but can't request the milestones because they already exist.The code was changed, so that parents of existing milestones are requested now as well in that case.