Skip to content
This repository was archived by the owner on Jan 13, 2023. It is now read-only.

add were_addresses_spent_from api #158

Merged
merged 1 commit into from
Feb 18, 2018
Merged

add were_addresses_spent_from api #158

merged 1 commit into from
Feb 18, 2018

Conversation

scottbelden
Copy link
Contributor

Resolves #157

A manual test looks like it's doing the right thing:

from iota import Iota

address = 'P9HZ9OCZONJFIKXVBJLTTGGJPIVX9ACRZEUNYFVSAWYPIMPJVKN9XNKXGUJSYE9NAMLPOGWOCEXPBGIKD'

api = Iota(uri, seed)
r = api.were_addresses_spent_from([address])
print(r)
{'states': [False], 'duration': 0}

todofixthis
todofixthis approved these changes Feb 17, 2018
View reviewed changes
Copy link
Contributor

@todofixthis todofixthis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks Scott!!

todofixthis
todofixthis suggested changes Feb 18, 2018
View reviewed changes
Copy link
Contributor

@todofixthis todofixthis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, shoot; I just noticed — could we rename test/commands/core/were_addresses_spent_from{ => _test}.py?

@scottbelden scottbelden force-pushed the were_addresses_spent_from branch from a39dc61 to 050c76b Compare February 18, 2018 14:09
@scottbelden
Copy link
Contributor Author

Good catch! Fixed.

todofixthis
todofixthis approved these changes Feb 18, 2018
View reviewed changes
Copy link
Contributor

@todofixthis todofixthis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gracias mate!

@todofixthis todofixthis merged commit 46d2d96 into iotaledger-archive:develop Feb 18, 2018
marko-k0 pushed a commit to marko-k0/iota.lib.py that referenced this pull request Jul 28, 2018
@todofixthis
Merge pull request iotaledger-archive#158 from scottbelden/were_addre…
3dd623c 
…sses_spent_from

add were_addresses_spent_from api
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@todofixthis todofixthis todofixthis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottbelden @todofixthis