This repository was archived by the owner on Aug 17, 2022. It is now read-only.
More Abstraction and Additional Clock Test Cases #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• I moved json-based result evaluation to a new protocol and made BulletMatch and Clock use it. • I generated more test cases for the clock challenge and made it use json (see above). I believe these are correct, but I’m open to criticism.
IanKeen
reviewed
Jan 9, 2017
|
|
||
| func generateDataset() -> [InputType] { | ||
| // Extract data from JSON file | ||
| let bundle = Bundle(for: BulletChallenge.self) |
There was a problem hiding this comment.
This is just to get the 'current' bundle correct?
If so it might be better to add a private junk class to use in place of BulletChallenge here so this doesn't mysteriously break in the future?
There was a problem hiding this comment.
Oh, whoops. I just copy-pasted that code from the BulletMatch code. Will fix.
missed this one when copy-pasting code from BulletMatch
Trailing commas break auto-indentation :c Also did some (very) minor cleanup
|
I'll leave it to @bugKrusha to merge since it is modifying his challenges a bit. But looks good to me! Thanks for the contribution! |
Because apparently autocomplete doesn’t like closures here. This works well for me
|
oh poop, I just merged another PR 'cause I thought this was already merged... gimme a min and I'll fix the conflicts |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• I moved json-based result evaluation to a new protocol and made
BulletMatch and Clock use it.
• I generated more test cases for the clock challenge and made it use
json (see above). I believe these are correct, but I’m open to
criticism.