Updated Travis to Xcode 8 #17
Conversation
There was a problem hiding this comment.
Looks good! Merging and then I'll do the clicks to get Travis set up.
@codesman thanks for getting CI set up for us. You rock!
@juliand665 nice work with all the challenges in one shot!
In the future though, let's keep the PRs separate. One PR for all the entries from @juliand665 and one that addressed #12 would have been my preferred set up, the merge conflicts should be handled after whichever one gets merged first, and preferably as a rebase.
| @@ -36,7 +36,8 @@ struct ClockChallenge: CodeChallengeType { | |||
| ethanSchatzlineClockEntry, | |||
| brandonShegaClockEntry, | |||
| matthijsClockEntry, | |||
| felixdumitClockEntry | |||
| felixdumitClockEntry, | |||
| juliand665ClockEntry, | |||
There was a problem hiding this comment.
I didn't think Swift supported trailing commas in array literals, but I see this builds and runs so 👍
| return combs | ||
| } | ||
|
|
||
| private let numbersToLetters: [Character: [String]] = [ // explicit declaration reduces compile time |
There was a problem hiding this comment.
I need to update the README for Swift 3, but this should be fileprivate. Don't worry about changing it @juliand665, I'll do it when I update the README, but just wanted to point it out here.
There was a problem hiding this comment.
Actually I take that back... I always forget that private is more restrictive than fileprivate, so nevermind! No changes needed :)
This includes changes from #16