This repository was archived by the owner on Aug 17, 2022. It is now read-only.
Bullet match #11
Merged
Bullet match #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aranasaurus
reviewed
Dec 28, 2016
| markings.append((bulletMarking, gunMarking)) | ||
| } | ||
| return markings | ||
| } |
There was a problem hiding this comment.
I don't like the dataset being random because then each test run is going to be run with different inputs, which feels like not the most empirical of comparisons. That may not matter for this particular problem, I haven't spent enough time with it to know, but I thought I'd bring it up.
The alternative would be to generate a dataset randomly as you've done here, and then write that out to a file and add that file to the repo and then just load the file here.
There was a problem hiding this comment.
Word. Lemme look into that.
|
Maybe a note should be added that mirroring is not allowed? |
aranasaurus
approved these changes
Jan 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bullet match challenge with solution.