Skip to content
This repository was archived by the owner on Aug 17, 2022. It is now read-only.

Add clock entry using Measurement #10

Merged
merged 2 commits into from
Dec 28, 2016

Conversation

felix-dumit
Copy link
Contributor

Wanted to try using the new Measurement api.
Since it's only available for iOS 10 I called into another one of the solutions if < iOS 10.

Copy link
Contributor

@aranasaurus aranasaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great submission, just the one change before I can merge it though :)

Also: sorry it took so long to get around to actually looking at this!

return (clockAngle(unit: .hours), clockAngle(unit: .minutes), clockAngle(unit: .seconds))

} else {
return brandonShegaClockEntry.block(input)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm... Maybe a fatalError here instead of returning someone else's solution?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☝️

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok just updated it ;)

Copy link
Contributor

@aranasaurus aranasaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aranasaurus aranasaurus merged commit 47b224d into iosdevelopershq:master Dec 28, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants