Skip to content

Conversation

@dpogue
Copy link
Contributor

@dpogue dpogue commented Oct 29, 2025

This drops the very old shelljs dependency in favour of NodeJS built-ins.

Moving from string commands to array arguments also increases safety by reducing the potential for argument injection attacks.

I flagged this as a major version bump, since we directly return the output of shell.exec or child_process.spawnSync and there are some differences in the return values (most notably the code property is now status).

@dpogue dpogue requested a review from erisu October 29, 2025 04:46
@dpogue dpogue mentioned this pull request Oct 29, 2025
6 tasks
Copy link
Contributor

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erisu erisu changed the title Replace shelljs.exec with child_process.spawnSync feat!: eeplace shelljs.exec with child_process.spawnSync Oct 29, 2025
@erisu erisu changed the title feat!: eeplace shelljs.exec with child_process.spawnSync feat!: replace shelljs.exec with child_process.spawnSync Oct 29, 2025
@dpogue dpogue merged commit 3635b07 into ios-control:master Oct 29, 2025
@dpogue dpogue deleted the spawnSync branch October 29, 2025 05:14
@erisu erisu added this to the 3.0.0 milestone Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants