Log DeviceDisconnected event when running with --json #516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabebear
approved these changes
Jun 1, 2021
|
@gabebear Thanks for approving! Do I need to do anything else to get this merged? |
You don't need to do anything, I was gonna let @ivanhernandez13 merge everything later... I'm also not sure why our checks aren't completing, might need to look into that but these should get merged soon-ish. |
|
I will look into the pending checks in a bit UPDATE: Looks like the Travis CI status update might have gotten lost. travis-ci.org showed that the checks had passed but no update was ever received. Restarting the build caused a new status to be reported and all checks are now green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #513: Device detached events are not printed with --json