fix: shotgun not gibbing unless aiming at feet #795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've played quake-fixed-shotgun-gib-2.mp4quake-fixed-shotgun-gib-3.mp4quake-fixed-shotgun-gib-4.mp4 |
Behind an off by default cvar, at least for now. Closes ioquake#794.
WofWca
force-pushed
the
fix-shotgun-gib-dont-change-maxs
branch
from
c818196 to
581e4a2
Compare
|
OK, I put this fix behind an off-by-default var, so that it's easier to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #794.
Note that now when shooting at two players
standing behind each other,
the second target will take less damage,
because the dead body of the first player will absorb the pellets
until it gets gibbed (that is, up to 4 pellets,
see
GIB_HEALTHandDEFAULT_SHOTGUN_DAMAGE).The purpose of the removed line is not entirely clear.
Maybe it's just leftover code,
because the height of a dead body is handled in
PM_CheckDuck.Before merging, please verify that this doesn't have
unintented side effects, I am not quite sure.
See the linked issue for details.