Warn users that the Makefile is now deprecated #750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now it's a skippable message, with REQUIRE_DEPRECATION_ACK=1 it becomes a hard error that the user must explicitly acknowledge.
timangus
force-pushed
the
makefile-deprecation-notice
branch
from
d46a72c to
d52024d
Compare
That 3 is kinda important.
timangus
commented
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in #748, this implements options 3/4/5 of the last section. It's mainly for @NuclearMonster, on the wording and timing, but I'm open to suggestions from anyone. It adds a skippable message to invocations of the Makefile, warning that the Makefile is going away. If we set REQUIRE_DEPRECATION_ACK=1 it becomes a hard error and the user must acknowledge the message to keep it working.