Set the overflow flag when the number of bits written reaches the maximum size #716
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently for example, if
bit
is 65536 andmaxsize
is 8192, thencursize
would be(65536 >> 3) + 1
= 8193, after the maximum size. (Netchan_Transmit
would drop an error when trying to send more than 49152 bytes)This commit simply sets the overflow flag when the number of bits written reaches the maximum size.
I didn't find better solutions. I first found this one solution:
However this change must be made in
MSG_ReadBits
as well, which would break compatibility with existing clients.