chore: switch to shared ioplane-base image - #42
Conversation
- Rewrite Containerfile as thin layer on localhost/ioplane-base:latest - Remove all duplicated base tooling (iohttpparser has no domain deps) - Update CLAUDE.md with base image build instructions
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1,265 +1,19 @@ | |||
| FROM oraclelinux:10 | |||
| # iohttpparser development image | |||
Check failure
Code scanning / Trivy
Image user should not be 'root' High
| # Build this image: | ||
| # podman build -t iohttpparser-dev:latest -f deploy/podman/Containerfile . | ||
|
|
||
| FROM localhost/ioplane-base:latest |
Check warning
Code scanning / Trivy
':latest' tag used Medium
| @@ -1,265 +1,19 @@ | |||
| FROM oraclelinux:10 | |||
| # iohttpparser development image | |||
Check notice
Code scanning / Trivy
No HEALTHCHECK defined Low
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 01ddf398d7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Build this image: | ||
| # podman build -t iohttpparser-dev:latest -f deploy/podman/Containerfile . | ||
|
|
||
| FROM localhost/ioplane-base:latest |
There was a problem hiding this comment.
Changing the dev image to FROM localhost/ioplane-base:latest makes the container build depend on an image that the GitHub runners never create or pull. In this repo, CI/coverage/release all only run docker build -f deploy/podman/Containerfile . (see .github/workflows/ci.yml:22, coverage.yml:22, and release.yml:23) and do not have a preceding step to build/tag localhost/ioplane-base:latest; on Docker, localhost/... is treated as a registry-qualified reference, so these workflows will fail at the image build step.
Useful? React with 👍 / 👎.
- Add scripts/lib/common.sh (shared quality gate functions from ioplane-base) - Rewrite quality.sh to source common.sh and use ioj_* functions - Add shellcheck gate step - All scripts pass shellcheck --severity=style
|
Unify agent instructions into a single AGENTS.md read by Claude Code, Codex and Gemini CLI. CLAUDE.md becomes a thin pointer importing it via @AGENTS.md.
2 participants
Summary
localhost/ioplane-base:latestTest plan
podman run --rm localhost/iohttpparser-dev:latest bash -c 'cmake --version && shellcheck --version'