Use micromamba instead of conda for faster builds - #81
Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Member
Author
|
The notebook that is failing is just an ERDDAP server timeout. It works locally as expected. This one is good to go. |
ocefpaf
marked this pull request as ready for review
May 19, 2022 17:02
Member
Author
|
@MathewBiddle the notebook 2016-11-15-glider_data_example.ipynb changed significantly. Iris no longer accept missing ancillary data, so most of our dataset will just crash with it. I took this opportunity to re-write the notebook using |
Merged
Contributor
|
Looks like I'm running into an issue with cf_xarray in glider notebook.
|
Member
Author
Can you send me you the results of Also, can you try to append
before reading? That issue should've been solved but you either have an older version of netcdf-c there or the problem resurfaced. |
Contributor
Adding |
Member
Author
|
BTW, you need to update your env. You have |
Contributor
|
But, it's Friday! Not sure I want to open that can of worms. Wish me luck 🤞 |
Contributor
|
after the update/reinstall the glider notebook is running smoothly again. Sorry for that. |
Contributor
|
Looks like iris is barking in the CF-UGRID notebook too. |
Member
Author
Not in the CIs, right? Are you running it locally? If so, I'll need your |
Contributor
|
Yes, I am testing it locally. Just to make sure folks would be able to run things locally. |
Member
Author
It works for me locally and in the CIs :-/ Maybe it is a Windows thing or just a temporary network problem. Did you try running it again? |
Contributor
|
I did with no luck. I'll try a "turn it off and back on again" and see if that fixes it. |
Contributor
|
Ugh, after reboot a new error: I'll work through this next week. |
Member
Author
That one is a known bug in udunits when the installation is in a different drive from the one you are running the notebook. See Unidata/UDUNITS-2#43 |
Contributor
|
Interesting. That went away when I updated udunits2. Now I'm back to the error above #81 (comment) Odd that a fresh install would give me these issues. 🤔 |
Member
Author
🤣 The "new" udunits2 was never really released but I guess we patched it and forgot. It is still odd that you got the old one in a fresh env.
Can you give me more context? What cell does that happen? What is the full traceback? |
Contributor
|
The first cell of the CF-UGRID-SGRID notebook returns this message: |
Member
Author
|
You have the same package versions I do and the same ones that are installed in the CIs :-/ I'll test it on Windows in a moment just to be sure. |
Member
Author
|
I can reproduce it. Quite puzzling b/c it does not happen on Linux with virtually the same environment. I'll debug this further but at this point I think I prefer to re-write this notebook and ditch iris altogether in the same fashion we did for the glide data notebook. |
ocefpaf
marked this pull request as draft
May 24, 2022 15:13
Member
Author
|
Making it a draft until I release odvc. |
ocefpaf
marked this pull request as ready for review
May 24, 2022 22:21
Member
Author
|
@MathewBiddle this one is ready for another round. You must install odvc >=1.0 first. |
Contributor
|
Cool! After updating odvc everything is working again! Last request is to add a line |
Member
Author
Done. I'll also add those to the PR template so we don't forget to do that in the future. |
Contributor
|
Looks good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should also cache the env too.