Update compliance-checker notebook with web API - #37
Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
ocefpaf
force-pushed
the
update_cc-api
branch
from
January 14, 2022 13:14
a835706 to
1cbb489
Compare
ocefpaf
marked this pull request as ready for review
January 14, 2022 13:14
Member
Author
|
@benjwadams is there an easy way to update the complicance-checker web to the latest (4.3.4) version? In theory that should fix the errors we are seeing in this notebook.
|
Member
Author
|
@MathewBiddle, @benjwadams updated compliance-checker-web to 5.0.0 but we are still hitting the same error. The web deployment use wheels and that seems to be using an older version of netcdf-c. See Unidata/netcdf4-python#1151 which may be the root of this problem. |
ocefpaf
force-pushed
the
update_cc-api
branch
from
September 13, 2023 13:34
bff934f to
4f46c2e
Compare
Member
Author
|
The broken tests should be fixed when #161 is merged. This particular notebook is passing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Web API is broken ATM so we cannot merge this yet.
Closes #29