Skip to content

Udate gallery for #13 - #199

Merged
MathewBiddle merged 1 commit into
ioos:mainfrom
ocefpaf:update_gallery
May 16, 2024
Merged

Udate gallery for #13#199
MathewBiddle merged 1 commit into
ioos:mainfrom
ocefpaf:update_gallery

Conversation

@ocefpaf

@ocefpaf ocefpaf commented May 16, 2024

Copy link
Copy Markdown
Member

@MathewBiddle can you take a look at the 3 keywords here, lines 330-332?

@MathewBiddle MathewBiddle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those look good!

@ocefpaf
ocefpaf requested a review from MathewBiddle May 16, 2024 17:17

@MathewBiddle MathewBiddle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good!

@MathewBiddle
MathewBiddle merged commit df10c50 into ioos:main May 16, 2024
@ocefpaf

ocefpaf commented May 16, 2024

Copy link
Copy Markdown
Member Author

@MathewBiddle the URL https://www.ncei.noaa.gov/archive/accession/0282699 is breaking the page build b/c it is not accessible. Is that temporary or did the URL change? Also, we need to skip R kernels. I'll do in another PR. We are not executing them to reduce the CI time, it was way too long and they rarely break due to stable CRAN versions of the packages.

@ocefpaf
ocefpaf deleted the update_gallery branch May 16, 2024 17:26
@MathewBiddle

Copy link
Copy Markdown
Contributor

Odd, I can access that url on my browser. I wonder if NCEI has some block on github requests?

@ocefpaf

ocefpaf commented May 16, 2024

Copy link
Copy Markdown
Member Author

Odd, I can access that url on my browser. I wonder if NCEI has some block on github requests?

Nope. It was down but it is back up. We can access it now as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants