Skip to content

Update PR template #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MathewBiddle merged 2 commits into from
Apr 29, 2024
Merged

Update PR template #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57f3ba8
Add an entry about the gallery card
ocefpaf Apr 18, 2024
f7c61f1
don't guess badges, leave it blank
ocefpaf Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/PULL_REQUEST_TEMPLATE/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ Thank you for send a Pull Request to our code gallery! When adding or updating a
- \[ \] The notebook has all the dependencies required to run in the IOOS env, if not please update the environment file.
- \[ \] You added a title, description, and a line with `Created: YYYY-MM-DD` in the first cell.
- \[ \] If you are updating a notebook add a line with `Updated: YYYY-MM-DD` below the created date.
- \[ \] Update the gallery entry to show your notebook thumbnail and description.
4 changes: 2 additions & 2 deletions jupyterbook/content/make_gallery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ def make_gallery_entry(nb_path):
:text-align: center
:shadow: md

{{bdg-primary}}`{nb_path.split("/")[1].replace("_", " ").title().strip("Notebooks").strip()}`
{{bdg-secondary}}`ERDDAP`
{{bdg-primary}}`DATA SERVICE`
{{bdg-secondary}}`TOPICAL KEYWORD`
{{bdg-info}}`{nb["metadata"]["language_info"]["name"]}`
^^^

Expand Down