Update NEW_NOTEBOOK.yml - #158
Merged
Merged
Conversation
fixing issue template
fixing issue
fixing again
Contributor
Author
|
Once merged, https://github.com/ioos/ioos_code_lab/blob/main/CONTRIBUTING.md should be updated. |
ocefpaf
reviewed
Sep 6, 2023
| label: Provide a description. | ||
| description: Please provide a detailed description of the suggested example below. | ||
| placeholder: "" | ||
| placeholder: The notebook should detail how to bring source data in, and create an interactive graphical timeseries of the data. |
Member
There was a problem hiding this comment.
Should we add in the placeholder: Example: phrase goes here to avoid users thinking that it is limited to the scope of the phrase. For example, reading it here gives the impression that it must be an interactive graphical representation of the data?
Contributor
Author
There was a problem hiding this comment.
good point. we could remove placeholder...
Member
There was a problem hiding this comment.
I like it! I just want to make sure folks understand that they are a text example, not a guide.
Member
|
Argh. I forgot about this PR and merged #163. I'll revert that one so we can keep work in this one first. |
Member
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


fixing issue template