Skip to content

Update NEW_NOTEBOOK.yml - #158

Merged
MathewBiddle merged 3 commits into
mainfrom
issue-template
Sep 28, 2023
Merged

Update NEW_NOTEBOOK.yml#158
MathewBiddle merged 3 commits into
mainfrom
issue-template

Conversation

@MathewBiddle

Copy link
Copy Markdown
Contributor

fixing issue template

@MathewBiddle
MathewBiddle requested a review from ocefpaf September 6, 2023 15:12
@MathewBiddle

Copy link
Copy Markdown
Contributor Author

Once merged, https://github.com/ioos/ioos_code_lab/blob/main/CONTRIBUTING.md should be updated.

label: Provide a description.
description: Please provide a detailed description of the suggested example below.
placeholder: ""
placeholder: The notebook should detail how to bring source data in, and create an interactive graphical timeseries of the data.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add in the placeholder: Example: phrase goes here to avoid users thinking that it is limited to the scope of the phrase. For example, reading it here gives the impression that it must be an interactive graphical representation of the data?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point. we could remove placeholder...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! I just want to make sure folks understand that they are a text example, not a guide.

@ocefpaf

ocefpaf commented Sep 28, 2023

Copy link
Copy Markdown
Member

Argh. I forgot about this PR and merged #163. I'll revert that one so we can keep work in this one first.

@ocefpaf

ocefpaf commented Sep 28, 2023

Copy link
Copy Markdown
Member

BTW, you already fixed most, if not all of the issues reported by GH:

Screenshot from 2023-09-28 11-43-50

Let me know if this one is good to merge!

@MathewBiddle
MathewBiddle merged commit 4c43f39 into main Sep 28, 2023
@MathewBiddle
MathewBiddle deleted the issue-template branch September 28, 2023 17:34
@ocefpaf

ocefpaf commented Sep 28, 2023

Copy link
Copy Markdown
Member

Yes!

Screenshot from 2023-09-28 15-18-13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants