Merge pull request #302 from ocefpaf/fix_301

Manually delete the file to avoid Windows aggressive file lock

erddapy/core/netcdf.py

@@ -1,5 +1,6 @@
 """Handles netCDF responses."""
 
+import platform
 from contextlib import contextmanager
 from pathlib import Path
 from typing import BinaryIO, Dict, Generator, Optional
@@ -27,9 +28,14 @@ def _tempnc(data: BinaryIO) -> Generator[str, None, None]:
     """Create a temporary netcdf file."""
     from tempfile import NamedTemporaryFile
 
+    # Let windows handle the file cleanup to avoid its aggressive file lock.
+    delete = True
+    if platform.system().lower() == "windows":
+        delete = False
+
     tmp = None
     try:
-        tmp = NamedTemporaryFile(suffix=".nc", prefix="erddapy_")
+        tmp = NamedTemporaryFile(suffix=".nc", prefix="erddapy_", delete=delete)
         tmp.write(data.read())
         tmp.flush()
         yield tmp.name

tests/test_netcdf_handling.py

@@ -1,6 +1,7 @@
 """Test netCDF loading."""
 
 import os
+import platform
 
 import pytest
 
@@ -23,6 +24,10 @@ def test__nc_dataset_in_memory_https():
 
 @pytest.mark.web
 @pytest.mark.vcr()
+@pytest.mark.skipif(
+    platform.system().lower() == "windows",
+    reason="does not remove the file on windows",
+)
 def test__tempnc():
     """Test temporary netcdf file."""
     url = "http://erddap.ioos.us/erddap/tabledap/allDatasets.nc"  # noqa