Fix tests using httpx errors

- Use base HTTPError class for exception handling in tests Tests using the Flash Slowwly API sometimes raise errors different than ReadTimeout or ConnectTimeout.
ioos · Dec 1, 2022 · 7c49ef6 · 7c49ef6
1 parent 51bdd40
commit 7c49ef6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/tests/test_erddapy.py b/tests/test_erddapy.py
@@ -109,7 +109,7 @@ def test_erddap_requests_kwargs():
 
     connection.requests_kwargs["timeout"] = timeout_seconds
 
-    with pytest.raises((httpx.ReadTimeout, httpx.ConnectTimeout)):
+    with pytest.raises(httpx.HTTPError):
         url = connection.get_download_url()
         _ = urlopen(url, requests_kwargs=connection.requests_kwargs)
 

diff --git a/tests/test_url_handling.py b/tests/test_url_handling.py
@@ -34,7 +34,7 @@ def test_urlopen_requests_kwargs():
     slowwly_milliseconds = (timeout_seconds + 1) * 1000
     slowwly_url = f"https://flash-the-slow-api.herokuapp.com/delay/{slowwly_milliseconds}/url/{base_url}"
 
-    with pytest.raises(httpx.ReadTimeout):
+    with pytest.raises(httpx.HTTPError):
         urlopen(slowwly_url, requests_kwargs={"timeout": timeout_seconds})