Remove pkg resources

[ocefpaf]

pkg_resources is notoriously slow and problematic. This PR tries to remove it from compliance-checker.

[codecov]

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 82.18%. Comparing base (c137e28) to head (d3ee89b).
Report is 7 commits behind head on develop.

Files	Patch %	Lines
compliance_checker/cf/util.py	50.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1039      +/-   ##
===========================================
+ Coverage    82.14%   82.18%   +0.04%     
===========================================
  Files           24       24              
  Lines         5170     5171       +1     
  Branches      1242     1242              
===========================================
+ Hits          4247     4250       +3     
+ Misses         623      622       -1     
+ Partials       300      299       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ocefpaf]

@benjwadams there is still one part of pkg_resources that we in the plugins stuff, the pkg_resources.working_set, but that one is a bit tricky and I'll leave it to another PR. This one is ready to review.

[ocefpaf]

@benjwadams this is hurting me in a setup where I have tons of packages and pkg_resources really drags everything down. While we still have the plugins to deal with, for now, this already helps speed things up. Do you mind taking a look?

[benjwadams]

Hi, sorry for the delay. Will have a look.

[benjwadams]

This should still work with Compliance Checker plugins, correct?

[benjwadams]

Just did a test in a pristine environment with cc-plugin-glider and it worked. However, when installing via pip, it looks like packaging package is missing, so should probably be added to requirements.txt.

[ocefpaf]

Just did a test in a pristine environment with cc-plugin-glider and it worked.

Cool. The plugin tests are also passing in the CIs. We do need to review the whole plugin system at some point though. But not now 😬

However, when installing via pip, it looks like packaging package is missing, so should probably be added to requirements.txt.

Done! I guess some other dependency is pulling it in the CIs b/c it did not fail there.

[ocefpaf]

The glider and ugrid plugin failures are an issue upstream I'll try to tackle them this week.

[ocefpaf]

With ioos/cc-plugin-glider#42 and ioos/cc-plugin-ugrid#19 this one is green again!

[jcermauwedu]

What is the status of trying to include this PR? I look forward to the reduced warnings generated by the test suite.

[ocefpaf]

What is the status of trying to include this PR? I look forward to the reduced warnings generated by the test suite.

I just rebased it to make it mergeable again.

@benjwadams do you want us to do more testing or are you good with this PR?

[ChrisBarker-NOAA]

I just duplicated this work in: #1059 -- not sure if I did a better or worse job. But it would be great if one or the other were merged.

[jcermauwedu]

@ChrisBarker-NOAA @ocefpaf @benjwadams I know, I almost did it a 3rd time with this PR(#1056) to fix some of the python tests. I had to undo those fixes when I remembered they were in this PR.

What can we do to help?

[ChrisBarker-NOAA]

What's the blocker to merging this now? Probably better than mine, as mine has a few checks failing -- might as well do this first, and then rebase mine and figure out what's up.

[ocefpaf]

What's the blocker to merging this now? Probably better than mine, as mine has a few checks failing -- might as well do this first, and then rebase mine and figure out what's up.

I'm waiting for Ben's response today and, if he is to busy, I'll self-merge this one. Stay tuned...

[ChrisBarker-NOAA]

great, thanks!

-CHB

[ChrisBarker-NOAA]

Thanks! Time for me to go update my PR, it may address the rest of these issues.