Return an array containing 0 when big integer is zero, to be more con…

…sistent. Fixes #280
ionspin · Feb 6, 2024 · d917cf0 · d917cf0
1 parent 6ab1048
commit d917cf0
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/...ommonMain/kotlin/com/ionspin/kotlin/bignum/integer/base63/array/BigInteger63Arithmetic.kt b/...ommonMain/kotlin/com/ionspin/kotlin/bignum/integer/base63/array/BigInteger63Arithmetic.kt
@@ -2228,6 +2228,9 @@ internal object BigInteger63Arithmetic : BigIntegerArithmetic {
     override fun toUByteArray(
         operand: ULongArray
     ): UByteArray {
+        if (operand == ZERO) {
+            return UByteArray(1) { 0U }
+        }
         val as64Bit = convertTo64BitRepresentation(operand).reversedArray()
         val result = UByteArray(as64Bit.size * 8)
         for (i in 0 until as64Bit.size) {

diff --git a/...um/src/jvmTest/kotlin/com/ionspin/kotlin/bignum/integer/base63/ByteArrayConversionTest.kt b/...um/src/jvmTest/kotlin/com/ionspin/kotlin/bignum/integer/base63/ByteArrayConversionTest.kt
@@ -826,4 +826,11 @@ class ByteArrayConversionTest {
         val kotlinBigBytes = IonSpinBigInteger.parseString("21000").toByteArray()
         Assert.assertArrayEquals(javaBigBytes, kotlinBigBytes)
     }
+
+    @Test
+    fun zeroToByteArray() {
+        val javaBigBytes = BigInteger("0").toByteArray()
+        val kotlinBigBytes = IonSpinBigInteger.parseString("0").toByteArray()
+        Assert.assertArrayEquals(javaBigBytes, kotlinBigBytes)
+    }
 }