Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ~/.auth to ~/.profitbricks-auth #59

Merged
merged 1 commit into from
Oct 9, 2017
Merged

Rename ~/.auth to ~/.profitbricks-auth #59

merged 1 commit into from
Oct 9, 2017

Conversation

vain
Copy link
Contributor

@vain vain commented Jun 23, 2017

Pull request for #53.

~/.auth is a very generic file name. At the very least, there should be a prefix such as profitbricks-, which is implemented in this PR.

@edevenport
Copy link
Contributor

Hello @vain and thank you for the PR. I agree this is a change that is much needed. The only problem I foresee is breaking backward compatibility with existing installations. Users will have to reconfigure their credentials.

We should either add backward compatibility (using .auth if present) and release as a minor version update or allow only .profitbricks-auth and release as a major version update.

We already have a NodeJS and CLI update for ProfitBricks Cloud API v4 in the pipeline; ETA two or three weeks which will be a major version release. Are you able to wait for that release to include this feature? If so, then I proceed to merge this into master.

@vain
Copy link
Contributor Author

vain commented Jun 28, 2017

Hi,

yeah, sure. This is not a pressing issue. We can surely wait a couple more weeks. :-)

@Sebbo94BY
Copy link

What about a simple check in profitbricks-cli, which checks, if .auth is available or not and if, then it simply should rename it to .profitbricks-auth? :)

Here is a very simple example in bash:

if [[ -f .auth ]]; then
	mv .auth .profitbricks-auth
fi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants