Fix: Retrieving dotnet runtimes hangs when there are too many runtimes installed #119
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test
Main tests.can get runtimes
hangs on my PC.Reason: ProjInfo calls
dotnet --list-runtimes
by executingdotnet
, waiting for it to finish, and then reading the output:proj-info/src/Ionide.ProjInfo/Library.fs
Lines 25 to 40 in 1c9317b
Important: First Waiting for exit, Then reading output
But: The executing Process blocks when its output buffer is full and not read (see Remarks for
Process.StandardOutput
).-> When there are too many runtimes installed (-> too many lines from
--list-runtimes
), callingdotnet --list-runtimes
hangs.I installed at least one new dotnet version over the last days (-> several additional runtimes). Which seems to just crossed the line between "working" and "buffer full"
(there are more runtimes than sdks -> happend with
--list-runtimes
, not (yet) with--list-sdks
)Fix: Read lines while executing