update FSAC and add support for new FSI options #2016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronfel
commented
Jun 17, 2024
src/Components/Fsi.fs
Outdated
Comment on lines
362
to
364
| Array.append | ||
| (Configuration.get Array.empty<string> "FSharp.fsiExtraParameters") | ||
| (Configuration.get Array.empty<string> "FSharp.FSIExtraInteractiveParameters") |
There was a problem hiding this comment.
@TheAngryByrd quick pointer here - to prevent user churn while the new FSI parameter names are rolled out I've joined the two parameter arrays. This is documented in the notes for the new configuration settings at least, what do you think?
|
Alright, this looks good! Will kick off a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes grammar fixes and fixes for an accidental double registration of the rename file command.