Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show package names only once #1920

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Conversation

dawedawe
Copy link
Contributor

@dawedawe dawedawe commented Aug 31, 2023

WHAT

🤖 Generated by Copilot at b03d263

Fixed a bug in the solution explorer that caused duplicate package references to appear. Modified packageRefs in src/Components/SolutionExplorer.fs to filter out duplicates by name.

🤖 Generated by Copilot at b03d263

packageRefs fixed
No more duplicates shown in
Solution explorer

🐛🗑️🗃️

WHY

Because there are multiple .dll files in the FSharp.Compiler.Service package, proj-info has two entries in the PackageReferences, which is fine. But here, we only want to show the package names.
image

HOW

🤖 Generated by Copilot at b03d263

  • Fix bug of duplicate package references in solution explorer by removing them before mapping to string (link)

Copy link
Member

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Thank you!

@TheAngryByrd TheAngryByrd merged commit 6f70c41 into ionide:main Aug 31, 2023
3 checks passed
@dawedawe dawedawe deleted the distinct_packagerefs branch August 31, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants