Types: import more *RegistrationOptions types from LSP spec #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razzmatazz
force-pushed
the
import-more-types-from-lsp
branch
from
83e4998 to
09ff020
Compare
razzmatazz
changed the title
razzmatazz
force-pushed
the
import-more-types-from-lsp
branch
3 times, most recently
from
87c62c3 to
fdb5b42
Compare
Contributor
Author
|
Ideally #49 would do this for us, but for now.. |
Co-authored-by: Adam Tao <tcx4c70@gmail.com>
razzmatazz
force-pushed
the
import-more-types-from-lsp
branch
from
fdb5b42 to
275d198
Compare
Contributor
Author
|
CC @baronfel |
Member
Yeah I need to get on that. one day... |
TheAngryByrd
approved these changes
May 9, 2024
| CompletionItem: CompletionItemOptions option | ||
| } | ||
|
|
||
| type CompletionRegistrationOptions = |
Member
There was a problem hiding this comment.
Looks like this might be missing workDoneProgress
CompletionRegistrationOptions extends CompletionOptions extends WorkDoneProgressOptions
Member
There was a problem hiding this comment.
There's 28 types that seem to extend WorkDoneProgressOptions and none of our current types care about it.
I'm ok without having it for this PR.
| RetriggerCharacters: char[] option | ||
| } | ||
|
|
||
| type SignatureHelpRegistrationOptions = |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR imports some of *RegistrationOptions types from LSP spec