InfoPanel generic parameter formatting & tests#870
Conversation
|
Hey @jcmrva, are you ready for this to be merged? it's in draft state right now so I didn't want to go forward with it until you were ready. |
|
Sorry, I meant to get back to this. Ideally, to make the test good, we'd want to parse the json and then the html. Let me know if you think it's worth holding it for that. |
|
@jcmrva excellent! I added json parsing of the expected responses and your tests are green locally 👍 HTML parsing would be quite a heavy additional load IMO, so I'm gonna let the CI pipeline run and merge it. Thanks for your efforts here, I'm hoping to release this change this weekend! |
… parameters in types for the info panel
5903b2d to
2aa6b3e
Compare
|
aha, the move to the |
|
This was released in FSAC 0.50.0 just now, and I hope to update ionide itself over the next couple days. |
Fix for ionide/ionide-vscode-fsharp#1583
I'll improve the tests.