[Repo Assist] fix: use Display instead of CanonicalTypeTextForSorting for signature help parameter types#1458
Merged
Krzysztof-Cieslak merged 2 commits intomainfrom Feb 23, 2026
Conversation
… help parameter types Fixes #1029 The parameter Documentation field in SignatureInformation was using p.CanonicalTypeTextForSorting, which returns fully-qualified type names (e.g., 'Microsoft.FSharp.Core.char' instead of 'char'). Switch to p.Display (TaggedText array converted to string) which uses the FCS display context for proper type name simplification. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
✅ Pull request created: #1458 |
This was referenced Feb 22, 2026
Member
|
/repo-assist add test case for this PR |
…hould use simplified type names Verifies that SignatureHelp parameter documentation does not show fully-qualified type names (e.g., Microsoft.FSharp.Core.char) but instead uses simplified names (e.g., char). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
✅ Commit pushed: |
Contributor
Author
|
🤖 This is an automated response from Repo Assist. I've added a regression test for issue #1029 to this PR. The test is in
The test builds cleanly with 0 errors.
|
Krzysztof-Cieslak
deleted the
repo-assist/fix-issue-1029-parameter-type-display-a985c1d46e790ddc
branch
github-actions bot
added a commit
that referenced
this pull request
Feb 24, 2026
Include all PRs merged since v0.83.0: - #1441: Fix SourceLink go-to-def failure on .NET 10 on Linux - #1452: Add FSharp.notifications.backgroundServiceProgress config option - #1449: Fix semantic token multiline range uint32 underflow - #1453: Fix spurious get/set rename in TextDocumentRename - #1454: Fix missing { interpolated string completion trigger - #1455: Fix non-ASCII path encoding in file URIs - #1456: Disable inline values by default to restore pipeline hints - #1457: Fix missing parens in function-type segments in AddExplicitTypeAnnotation - #1458: Fix signature help parameter types showing fully-qualified names - #1463: Fix seealso href/langword XML doc rendering Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Repo Assist, an automated AI assistant.
Closes #1029
Root Cause
In
AdaptiveFSharpLspServer.fs, theTextDocumentSignatureHelphandler was usingp.CanonicalTypeTextForSortingfor theDocumentationfield of eachParameterInformation. This property is designed for sorting purposes and returns fully-qualified type names — e.g.,Microsoft.FSharp.Core.charinstead ofchar, orMicrosoft.FSharp.Core.stringinstead ofstring.Fix
Switch to
p.Display(aTaggedText array), converted to a plain string viaArray.map (fun t -> t.Text) |> String.concat "". TheDisplayproperty uses the FCS display context for proper type name simplification, so it rendersarr: char[]instead ofarr: Microsoft.FSharp.Core.char[].Trade-offs
Displayincludes both the parameter name and type (e.g.,arr: char[]), whereas the old code showed only the type. This is actually more informative for theDocumentationtooltip.Labelfield already carries just the parameter name, so the documentation beingname: typeis the natural complement.Test Status
Build succeeded on
net8.0with 0 errors, 0 warnings.