Skip to content

Conversation

@baronfel
Copy link
Contributor

@baronfel baronfel commented May 26, 2024

We're now fully updated to using the generated types. The primary impactful changes are

  • uint32s virtually everywhere for positions/offsets (which per spec cannot be negative)
  • no more aliased types for several un-tagged unions (for example, MarkedString) - these now use the U2.C1, U2.C2, etc case constructors directly

@baronfel baronfel changed the title Draft update to LangaugeServerProtocol based on generated metamodel Draft update to LanguageServerProtocol based on generated metamodel May 26, 2024
@baronfel baronfel force-pushed the languageserverprotocol-gentype-bump branch from e39d814 to b47216a Compare May 26, 2024 20:13
@baronfel baronfel force-pushed the languageserverprotocol-gentype-bump branch from f2c0734 to 9c71cf7 Compare May 29, 2024 03:15
@baronfel
Copy link
Contributor Author

Only 10 tests failing now!

@baronfel
Copy link
Contributor Author

@TheAngryByrd do you have any tips for debugging timing issues in the tests? Some of the tests are around completions, and it seems like this order of operations isn't occurring like expected:

  • textDocument/didOpen
  • textDocument/didChange
    • leads to re-typecheck
  • textDocument/completion
    • checks against stale typecheck therefore no/incorrect completions at expected location

@TheAngryByrd
Copy link
Member

textDocument/didOpen
textDocument/didChange

I think a lot of unintended problems stem from "notifications" like theres were we don't return anything to the client and only are able to log errors. And if these don't happen, nothing else will work. Turning on debug logs is the only way unless we somehow get to a point where we can collect Traces/Logs per test.

@TheAngryByrd TheAngryByrd force-pushed the languageserverprotocol-gentype-bump branch from 46c3489 to 03b08cc Compare June 12, 2024 17:01
@baronfel baronfel force-pushed the languageserverprotocol-gentype-bump branch from 99b38f9 to 5fe7e92 Compare June 14, 2024 02:20
@baronfel baronfel changed the title Draft update to LanguageServerProtocol based on generated metamodel Update logic and models to use Ionide.LanguageServerProtocol types generated from LSP metamodel Jun 14, 2024
@baronfel baronfel marked this pull request as ready for review June 14, 2024 03:54
@baronfel baronfel merged commit e0bbe10 into ionide:main Jun 14, 2024
@baronfel baronfel deleted the languageserverprotocol-gentype-bump branch June 14, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants