-
Notifications
You must be signed in to change notification settings - Fork 163
Update logic and models to use Ionide.LanguageServerProtocol types generated from LSP metamodel #1301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update logic and models to use Ionide.LanguageServerProtocol types generated from LSP metamodel #1301
Conversation
e39d814 to
b47216a
Compare
f2c0734 to
9c71cf7
Compare
|
Only 10 tests failing now! |
|
@TheAngryByrd do you have any tips for debugging timing issues in the tests? Some of the tests are around completions, and it seems like this order of operations isn't occurring like expected:
|
I think a lot of unintended problems stem from "notifications" like theres were we don't return anything to the client and only are able to log errors. And if these don't happen, nothing else will work. Turning on debug logs is the only way unless we somehow get to a point where we can collect Traces/Logs per test. |
46c3489 to
03b08cc
Compare
99b38f9 to
5fe7e92
Compare
We're now fully updated to using the generated types. The primary impactful changes are
U2.C1,U2.C2, etc case constructors directly