Use of the now public Range propery of PreXmlDoc (#1128)

* Having the latest fsc, we can make use of the now public Range property of PreXmlDoc to save resources * format
ionide · Jul 4, 2023 · 6cfa454 · 6cfa454
1 parent 7fc82db
commit 6cfa454
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/FsAutoComplete/CodeFixes/AddMissingXmlDocumentation.fs b/src/FsAutoComplete/CodeFixes/AddMissingXmlDocumentation.fs
@@ -14,21 +14,21 @@ let title = "Add missing XML documentation"
 
 let private tryGetExistingXmlDoc (pos: FSharp.Compiler.Text.Position) (xmlDoc: PreXmlDoc) =
   let tryGetSummaryIfContainsPos (xd: PreXmlDoc) =
-    let d = xd.ToXmlDoc(false, None)
+    if rangeContainsPos xd.Range pos then
+      let d = xd.ToXmlDoc(false, None)
 
-    if rangeContainsPos d.Range pos then
       if Array.isEmpty d.UnprocessedLines then
         None
       elif d.UnprocessedLines |> Array.exists (fun s -> s.Contains("<summary>")) then
-        Some(d.UnprocessedLines, d.Range)
+        Some(d.UnprocessedLines, xd.Range)
       else
         let lines =
           match d.UnprocessedLines with
           | [||] -> [| " <summary></summary>" |]
           | [| c |] -> [| $" <summary>%s{c.Trim()}</summary>" |]
           | cs -> [| yield " <summary>"; yield! cs; yield " </summary>" |]
 
-        Some(lines, d.Range)
+        Some(lines, xd.Range)
     else
       None
 

diff --git a/src/FsAutoComplete/CodeFixes/ConvertTripleSlashCommentToXmlTaggedDoc.fs b/src/FsAutoComplete/CodeFixes/ConvertTripleSlashCommentToXmlTaggedDoc.fs
@@ -14,9 +14,9 @@ let title = "Convert '///' comment to XML-tagged doc comment"
 
 let private containsPosAndNotEmptyAndNotElaborated (pos: FSharp.Compiler.Text.Position) (xmlDoc: PreXmlDoc) =
   let containsPosAndNoSummaryPresent (xd: PreXmlDoc) =
-    let d = xd.ToXmlDoc(false, None)
+    if rangeContainsPos xd.Range pos then
+      let d = xd.ToXmlDoc(false, None)
 
-    if rangeContainsPos d.Range pos then
       let summaryPresent =
         d.UnprocessedLines |> Array.exists (fun s -> s.Contains("<summary>"))