Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(angular, angular-standalone): remove enableProdMode() #1838

Merged
merged 4 commits into from
Jul 3, 2024

Conversation

danielsogl
Copy link
Contributor

The function call can be removed: https://angular.io/api/core/enableProdMode#description

@danielsogl danielsogl requested a review from a team as a code owner April 13, 2024 22:28
@danielsogl danielsogl requested review from averyjohnston and removed request for a team April 13, 2024 22:28
@thetaPC thetaPC requested review from a team and JoaoFerreira-FrontEnd and removed request for averyjohnston and a team June 6, 2024 20:01
@thetaPC thetaPC changed the title refactor(angular-standalone): remove unnecessary enableProdMode function refactor(angular, angular-standalone): remove enableProdMode() Jun 24, 2024
@thetaPC
Copy link
Contributor

thetaPC commented Jun 24, 2024

The build issues will be fixed after this PR is merged in.

Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thetaPC thetaPC merged commit 4f4b246 into ionic-team:main Jul 3, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants