Skip to content

added support via view directive to hide tab bar #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sicsol wants to merge 2 commits into from
Closed

added support via view directive to hide tab bar #419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39b3f9c
added support via view directive to hide tab bar
sicsol Jan 15, 2014
7035356
fixed bug with hide tab bar was in wrong place
sicsol Jan 15, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions dist/js/ionic-angular.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2360,6 +2360,15 @@ angular.module('ionic.ui.tabs', ['ionic.service.view'])
link: function($scope, $element, $attr, tabsCtrl) {
$element.addClass($scope.tabsType);
$element.addClass($scope.tabsStyle);

// Show and hide tab bar
$scope.$on('viewState.showTabBar', function(e, showTabBar) {
if(showTabBar === false) {
$element[0].classList.add('invisible');
} else {
$element[0].classList.remove('invisible');
}
});
}
};
})
Expand Down Expand Up @@ -2619,6 +2628,7 @@ angular.module('ionic.ui.viewState', ['ionic.service.view', 'ionic.service.gestu
alignTitle: '@',
hideBackButton: '@',
hideNavBar: '@',
hideTabBar: '@',
animation: '@'
},

Expand All @@ -2642,6 +2652,9 @@ angular.module('ionic.ui.viewState', ['ionic.service.view', 'ionic.service.gestu
// Should the nav bar be hidden for this view or not?
$rootScope.$broadcast('viewState.showNavBar', ($scope.hideNavBar !== 'true') );

// Should the tab bar be hidden for this view or not?
$rootScope.$broadcast('viewState.showTabBar', ($scope.hideTabBar !== 'true') );

// watch for changes in the left buttons
var deregLeftButtons = $scope.$watch('leftButtons', function(value) {
$scope.$emit('viewState.leftButtonsChanged', $scope.leftButtons);
Expand Down
2 changes: 1 addition & 1 deletion dist/js/ionic-angular.min.js
View file
Open in desktop

Large diffs are not rendered by default.

9 changes: 9 additions & 0 deletions js/ext/angular/src/directive/ionicTabBar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,15 @@ angular.module('ionic.ui.tabs', ['ionic.service.view'])
link: function($scope, $element, $attr, tabsCtrl) {
$element.addClass($scope.tabsType);
$element.addClass($scope.tabsStyle);

// Show and hide tab bar
$scope.$on('viewState.showTabBar', function(e, showTabBar) {
if(showTabBar === false) {
$element[0].classList.add('invisible');
} else {
$element[0].classList.remove('invisible');
}
});
}
};
})
Expand Down
4 changes: 4 additions & 0 deletions js/ext/angular/src/directive/ionicViewState.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ angular.module('ionic.ui.viewState', ['ionic.service.view', 'ionic.service.gestu
alignTitle: '@',
hideBackButton: '@',
hideNavBar: '@',
hideTabBar: '@',
animation: '@'
},

Expand All @@ -189,6 +190,9 @@ angular.module('ionic.ui.viewState', ['ionic.service.view', 'ionic.service.gestu
// Should the nav bar be hidden for this view or not?
$rootScope.$broadcast('viewState.showNavBar', ($scope.hideNavBar !== 'true') );

// Should the tab bar be hidden for this view or not?
$rootScope.$broadcast('viewState.showTabBar', ($scope.hideTabBar !== 'true') );

// watch for changes in the left buttons
var deregLeftButtons = $scope.$watch('leftButtons', function(value) {
$scope.$emit('viewState.leftButtonsChanged', $scope.leftButtons);
Expand Down