feat(modal): add IonModalToken for injecting modal elements in Angular components #30474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ShaneK
changed the title
thetaPC
requested changes
Jun 17, 2025
…eating and accessing modals through angular
|
Shouldn't this go into |
brandyscarney
approved these changes
Jun 23, 2025
packages/angular/test/base/src/app/standalone/home-page/home-page.component.html
Outdated
Show resolved
Hide resolved
packages/angular/test/base/src/app/standalone/programatic-modal/modal/modal.component.html
Outdated
Show resolved
Hide resolved
...ages/angular/test/base/src/app/standalone/programatic-modal/programatic-modal.component.html
Outdated
Show resolved
Hide resolved
packages/angular/test/base/src/app/standalone/programatic-modal/programatic-modal.component.ts
Outdated
Show resolved
Hide resolved
packages/angular/test/base/src/app/standalone/programatic-modal/programatic-modal.component.ts
Outdated
Show resolved
Hide resolved
packages/angular/test/base/src/app/standalone/app-standalone/app.routes.ts
Outdated
Show resolved
Hide resolved
...ges/angular/test/apps/ng19/src/app/standalone/programatic-modal/programatic-modal.service.ts
Outdated
Show resolved
Hide resolved
...s/angular/test/apps/ng19/src/app/standalone/programatic-modal/programatic-modal.component.ts
Outdated
Show resolved
Hide resolved
...s/angular/test/apps/ng19/src/app/standalone/programatic-modal/programatic-modal.component.ts
Outdated
Show resolved
Hide resolved
...s/angular/test/apps/ng19/src/app/standalone/programatic-modal/programatic-modal.component.ts
Outdated
Show resolved
Hide resolved
|
Changed target branch and fixed the spelling of programmatic, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #internal
What is the current behavior?
Currently, we provide no injection access to angular modals, which makes it difficult to connect to their events normally.
What is the new behavior?
This is an attempt to allow easier programmatic access to the internals of injected modals.
Does this introduce a breaking change?
Other information
Dev build:
8.6.2-dev.11749830167.1460aa73