fix(toast): swipe gesture works with custom container layout#29999
Merged
tanner-reits merged 1 commit intoionic-team:mainfrom Nov 14, 2024
Merged
fix(toast): swipe gesture works with custom container layout#29999tanner-reits merged 1 commit intoionic-team:mainfrom
tanner-reits merged 1 commit intoionic-team:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sean-perkins
approved these changes
Nov 13, 2024
Contributor
sean-perkins
left a comment
sean-perkins
left a comment
There was a problem hiding this comment.
The change makes sense to me. The toast container doesn't fill the entire horizontal space of the wrapper, but the wrapper is the visual element that users "interact" with, with the swipe gesture.
sean-perkins
requested review from
tanner-reits
and removed request for
christian-bromann
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #29998
What is the current behavior?
Applying a custom layout to
ion-toast::part(container), for examplewidth: 50%, will make the part of the toast outside this element's bounds non-interactive for swiping gestures.What is the new behavior?
Can swipe from anywhere on the toast with custom layout applied to ::part(container)
Does this introduce a breaking change?
Other information
Kapture.2024-11-04.at.18.36.19.mp4
Kapture.2024-11-04.at.18.35.11.mp4