fix(range): emit correct value when knob is at start of bar #29820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sean-perkins
commented
Aug 30, 2024
| @@ -449,7 +449,7 @@ export class Range implements ComponentInterface { | |||
| */ | |||
| private onEnd(detail: GestureDetail | MouseEvent) { | |||
| const { contentEl, initialContentScrollY } = this; | |||
| const currentX = (detail as GestureDetail).currentX || (detail as MouseEvent).clientX; | |||
| const currentX = (detail as GestureDetail).currentX ?? (detail as MouseEvent).clientX; | |||
There was a problem hiding this comment.
The problem here was that detail.currentX can evaluate to 0 and 0 || detail.clientX will treat the 0 as falsy and return the detail.clientX which is undefined.
Instead we wanted to take the currentX or take the clientX if the value is null/undefined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #29792
What is the current behavior?
When the user drags the range knob (most easily reproduced in fullscreen mode) and the gesture emits a current x position of
0, the range incorrectly emits a value ofNaN.What is the new behavior?
ion-rangedoes not emitNaNand instead emits the correct range value for the knobDoes this introduce a breaking change?
Other information