Skip to content

Conversation

@liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Nov 18, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Nightlies are failing to push to GitHub because I named the temp branch in such a way that it falls under branch protection rules for our version branches: https://github.com/ionic-team/ionic-framework/actions/runs/3494606832/jobs/5850589152

What is the new behavior?

  • Nightly branches are now prefixed with "tmp-" to indicate that they are temporary and to avoid falling into branch protection for version branches.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi liamdebeasi marked this pull request as ready for review November 18, 2022 15:48
@liamdebeasi liamdebeasi requested a review from a team as a code owner November 18, 2022 15:48
@liamdebeasi liamdebeasi merged commit bacc4f3 into main Nov 18, 2022
@liamdebeasi liamdebeasi deleted the nightly-temp branch November 18, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants